Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable29] don't error if we can't find a trashbin item for a file when looking … #3073

Merged
merged 3 commits into from
Aug 30, 2024
Merged

[stable29] don't error if we can't find a trashbin item for a file when looking … #3073

merged 3 commits into from
Aug 30, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 21, 2024

Backport of PR #2813

@backportbot backportbot bot added the 3. to review Items that need to be reviewed label Jul 21, 2024
@skjnldsv
Copy link
Member 

1) OCA\groupfolders\tests\ACL\ACLManagerTest::testGetACLPermissionsForPathNoRules
TypeError: OCA\GroupFolders\ACL\ACLManager::__construct(): Argument #3 ($logger) must be of type Psr\Log\LoggerInterface, Mock_IUser_c6e82b42 given, called in /home/runner/actions-runner/_work/groupfolders/groupfolders/apps/groupfolders/tests/ACL/ACLManagerTest.php on line 88

/home/runner/actions-runner/_work/groupfolders/groupfolders/apps/groupfolders/lib/ACL/ACLManager.php:38
/home/runner/actions-runner/_work/groupfolders/groupfolders/apps/groupfolders/tests/ACL/ACLManagerTest.php:88
/home/runner/actions-runner/_work/groupfolders/groupfolders/apps/groupfolders/tests/ACL/ACLManagerTest.php:57

Related

@skjnldsv skjnldsv added 2. developing Items that are currently under development and removed 3. to review Items that need to be reviewed labels Aug 28, 2024
@come-nc
Copy link
Contributor

come-nc commented Aug 29, 2024

Needs #3043

@solracsf @come-nc
fix: ACLManager tests
01713ae 
Signed-off-by: Git'Fellow <[email protected]>

chore: optimize code

Signed-off-by: Git'Fellow <[email protected]>

fix: call logger

Signed-off-by: Git'Fellow <[email protected]>

fix: Add LoggerInterface

Signed-off-by: Git'Fellow <[email protected]>

Fix: Typo

Signed-off-by: Git'Fellow <[email protected]>
@skjnldsv skjnldsv merged commit 0857bbf into stable29 Aug 30, 2024
43 checks passed
@skjnldsv skjnldsv deleted the backport/2813/stable29 branch August 30, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@icewind1991 icewind1991

Labels
2. developing Items that are currently under development
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @come-nc @icewind1991 @solracsf